trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From prashanth-vasudev <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #610: TRAFODION-2067 support cdh5.7 & hbase...
Date Tue, 02 Aug 2016 17:16:20 GMT
Github user prashanth-vasudev commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/610#discussion_r73197524
  
    --- Diff: core/sqf/src/seatrans/hbase-trx/src/main/java/org/apache/hadoop/hbase/regionserver/transactional/KeyValueListScanner.java.tmpl
---
    @@ -48,7 +50,7 @@ public class KeyValueListScanner implements KeyValueScanner {
             Collections.sort(data, this.comparator);
             this.iter = data.iterator();
             if (!data.isEmpty()) {
    -            this.current = KeyValue.createFirstOnRow(data.get(0).getRow());
    +            this.current = KeyValueUtil.createFirstOnRow(CellUtil.cloneRow(data.get(0)));
    --- End diff --
    
    Please check cloning of the row here is absolutely needed. This is going to get very expensive
memory consumption. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message