trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #634: JIRA TRAFODION-2137 metadata access p...
Date Tue, 02 Aug 2016 21:13:28 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/634#discussion_r73238816
  
    --- Diff: core/sql/arkcmp/CmpStoredProc.cpp ---
    @@ -273,77 +273,75 @@ NABoolean CmpSPOutputFormat::SetFormat(Lng32 nCols,
       nCols_ = nCols;
       // set up tableDesc_, allocate the storage from allocate routine,
       // so the delete of the tableDesc_ could be done correctly. 
    -  // As in sqlcat/desc.h readtabledef_allocate_desc(), allocate routine gets 
    +  // As in sqlcat/desc.h TrafAllocateDDLdesc(), allocate routine gets 
    --- End diff --
    
    Should this comment say TrafDDLdesc.h instead of desc.h?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message