trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <>
Subject [GitHub] incubator-trafodion pull request #634: JIRA TRAFODION-2137 metadata access p...
Date Tue, 02 Aug 2016 21:28:13 GMT
Github user DaveBirdsall commented on a diff in the pull request:
    --- Diff: core/sql/arkcmp/CmpStoredProc.cpp ---
    @@ -273,77 +273,75 @@ NABoolean CmpSPOutputFormat::SetFormat(Lng32 nCols,
       nCols_ = nCols;
       // set up tableDesc_, allocate the storage from allocate routine,
       // so the delete of the tableDesc_ could be done correctly. 
    -  // As in sqlcat/desc.h readtabledef_allocate_desc(), allocate routine gets 
    +  // As in sqlcat/desc.h TrafAllocateDDLdesc(), allocate routine gets 
       // the storage from HEAP ( i.e. CmpCommon::statementHeap() ). 
       // Likewise, copyString should be the same implementation as in 
       // readRealArk.cpp. It was externalized originally, but being put as
       // static function by someone. Currently the code copyString is cloned
       // in the beginning of the file. ( which will allocate the memory from
       // statementHeap ).
    -  desc_struct* table_desc = readtabledef_allocate_desc(DESC_TABLE_TYPE);
    +  TrafDesc* table_desc = TrafAllocateDDLdesc(DESC_TABLE_TYPE, NULL);
    --- End diff --
    Why not just make table_desc an object of type TrafTableDesc * and avoid the repetitive
casting below?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message