trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anoopsharma00 <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #634: JIRA TRAFODION-2137 metadata access p...
Date Tue, 02 Aug 2016 22:32:00 GMT
Github user anoopsharma00 commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/634#discussion_r73250622
  
    --- Diff: core/sql/arkcmp/CmpStoredProc.cpp ---
    @@ -363,7 +361,7 @@ NABoolean CmpSPOutputFormat::getColumnDesc(SP_FIELDDESC_STRUCT* fDesc,
         {
           // convert ElemDDLColViewDef into CatColumn, then column_desc
           if ( !ElemDDLColDef2ColumnDescStruct
    -	   (elemDDL, tableDesc_->body.table_desc.tablename, colsDesc) )
    +	   (elemDDL, tableDesc_->tableDesc()->tablename, colsDesc) )
    --- End diff --
    
    For this checkin, wanted to keep the code structure somewhat similar to how it was.
    That made it easier to make changes (lots of search and replace).
    The old code used desc_struct which was replaced by TrafDesc class in the new code.
    For a later checkin, we can change to using the underlying class instead of base class.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message