trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mashengchen <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #610: TRAFODION-2067 support cdh5.7 & hbase...
Date Wed, 03 Aug 2016 06:19:48 GMT
Github user mashengchen commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/610#discussion_r73286115
  
    --- Diff: core/sqf/src/seatrans/hbase-trx/src/main/java/org/apache/hadoop/hbase/coprocessor/transactional/SsccRegionEndpoint.java.tmpl
---
    @@ -236,7 +236,11 @@ CoprocessorService, Coprocessor {
     
       private HRegionInfo regionInfo = null;
       private HRegion m_Region = null;
    +#ifdef CDH5.7 APACHE1.2
    +  private HRegion t_Region = null;
    --- End diff --
    
    the qualify of HRegion.getScanner(final Scan scan, final List<KeyValueScanner> scanners)
has changed to public in hbase1.2, what the TransactionalRegion do before hbase1.2 is to make
getScanner to be public , so in hbase1.2 it can change back to HRegion. and it may help to
remove "hbase.hregion.impl" in hbase-site.xml in the future.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message