trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zellerh <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #637: [TRAFODION-2138] Hive scan on wide ta...
Date Wed, 03 Aug 2016 22:01:46 GMT
Github user zellerh commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/637#discussion_r73429919
  
    --- Diff: core/sql/optimizer/BindRelExpr.cpp ---
    @@ -7582,6 +7582,24 @@ RelExpr *Scan::bindNode(BindWA *bindWA)
             }
         }
     
    +   if (naTable->isHiveTable() && 
    +       !(naTable->getClusteringIndex()->getHHDFSTableStats()->isOrcFile() ||
    +	 naTable->getClusteringIndex()->getHHDFSTableStats()
    +	 ->isSequenceFile()) &&
    +       (CmpCommon::getDefaultNumeric(HDFS_IO_BUFFERSIZE_BYTES) == 0) && 
    +       (naTable->getRecordLength() >
    +	CmpCommon::getDefaultNumeric(HDFS_IO_BUFFERSIZE)*1024))
    +     {
    +       // do not raise error if buffersize is set though buffersize_bytes.
    --- End diff --
    
    Another thing you can do is to make HDFS_IO_BUFFERSIZE a FLOAT, then you can specify sizes
of less than one KB as well. That would be less confusing. I'm not sure I understand how you
wanted to use this as a backdoor and don't have a strong opinion, you will know better how
you want to use it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message