trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sureshsubbiah <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #642: [TRAFODION-2119] create table report ...
Date Fri, 05 Aug 2016 22:53:54 GMT
Github user sureshsubbiah commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/642#discussion_r73770370
  
    --- Diff: core/sql/optimizer/EncodedKeyValue.cpp ---
    @@ -69,7 +69,14 @@ NAString * getMinMaxValue(TrafDesc * column,
       
       Lng32 buflen = type->getTotalSize();
       char * buf = new char[buflen]; // deleted at the end of this method
    -
    +  if (type->supportsSQLnullPhysical())
    +  {
    +      Lng32 nullHdrSize = type->getSQLnullHdrSize();
    +      for(int i = 0; i < nullHdrSize; i++)
    --- End diff --
    
    Prior to this change what was being placed in the null bytes by this method?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message