trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From traflm <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #639: [TRAFODION-2117] add SQL support of E...
Date Sat, 06 Aug 2016 03:21:14 GMT
Github user traflm commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/639#discussion_r73779962
  
    --- Diff: core/sql/optimizer/RelExpr.cpp ---
    @@ -6630,6 +6630,23 @@ const NAString Intersect::getText() const
     }
     
     // -----------------------------------------------------------------------
    +// // member functions for class Except
    +// // -----------------------------------------------------------------------
    +Except::Except(RelExpr *leftChild,
    +             RelExpr *rightChild)
    +: RelExpr(REL_EXCEPT, leftChild, rightChild)
    +{ setNonCacheable(); }
    --- End diff --
    
    I don't know either, but SET operations like UNION is also set as non cacheable. So I
feel we should keep it now. I will try to study more on this later.
    
    showshape works:
    >>showshape select eno,ename,dno from t021 except select * from t022;
    I
    control query shape hybrid_hash_join(scan(path 'TRAFODION.SEABASE.T021',
    forward, blocks_per_access 1 , mdam off),
    scan(path 'TRAFODION.SEABASE.T022', forward, blocks_per_access 1
    , mdam off));
    
    --- SQL operation complete.
    >>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message