trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertamarton <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #644: Trafodion 1788
Date Tue, 09 Aug 2016 16:32:24 GMT
Github user robertamarton commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/644#discussion_r74094360
  
    --- Diff: core/sql/sqlcomp/PrivMgrMD.h ---
    @@ -187,6 +202,25 @@ class ObjectUsage
       PrivMgrDesc originalPrivs;
       PrivMgrDesc updatedPrivs;
     
    +  void copyColumnReferences(const std::vector<ColumnReference *> *refsToCopy)
    +  {
    +    if (refsToCopy == NULL)
    +      columnReferences = NULL;
    +    else
    +    {
    +      columnReferences = new std::vector<ColumnReference *>;
    +      for (int i = 0; i < refsToCopy->size(); i++)
    +      {
    +        ColumnReference *newRef = new ColumnReference;
    --- End diff --
    
    Good suggestion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message