trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ryzuo <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #642: [TRAFODION-2119] create table report ...
Date Tue, 09 Aug 2016 17:18:34 GMT
Github user ryzuo commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/642#discussion_r74102722
  
    --- Diff: core/sql/optimizer/EncodedKeyValue.cpp ---
    @@ -68,14 +68,22 @@ NAString * getMinMaxValue(TrafDesc * column,
         return NULL;
       
       Lng32 buflen = type->getTotalSize();
    +  Lng32 nullHdrSize = 0;
       char * buf = new char[buflen]; // deleted at the end of this method
    -
    +  if (type->supportsSQLnullPhysical())
    +  {
    +      nullHdrSize = type->getSQLnullHdrSize();
    +      for(int i = 0; i < nullHdrSize; i++)
    --- End diff --
    
    Not familiar with this part, but would it be more efficient to use memset() to do the
initial work rather than using a for loop? Just my opinion...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message