trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #651: Trafodion 2140
Date Wed, 10 Aug 2016 17:14:46 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/651#discussion_r74287912
  
    --- Diff: core/sql/ustat/hs_cli.cpp ---
    @@ -524,12 +531,14 @@ Lng32 HSSample::create(NAString& tblName, NABoolean unpartitioned,
NABoolean isP
                tableOptions = " WITH PARTITIONS";
             // If a transaction is running, the table needs to be created as audited.
             // Otherwise, create table as non-audited.
    +        /* TEMPTEMP. Dave need to validate this change.
             if (TM->InTransaction())
               tableOptions += " ATTRIBUTE AUDIT";
             else
               tableOptions += " ATTRIBUTE NO AUDIT";
     
             tableOptions += getTempTablePartitionInfo(unpartitioned, isPersSample);
    +        */
    --- End diff --
    
    Commenting out the "ATTRIBUTE [NO] AUDIT" stuff is fine. (Indeed it appears that Trafodion
does not support non-audited tables. I tried creating one and DMLs on it fail with error 4211.)
But the getTempTablePartitionInfo method supplies a SALT clause, which is important to get
a nice degree of parallelism when we populate the sample table. So I think we want to keep
that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message