trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lanbb <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #650: [TRAFODION-2034] fix bug that odb wil...
Date Thu, 11 Aug 2016 02:38:59 GMT
Github user lanbb commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/650#discussion_r74362971
  
    --- Diff: core/conn/odb/src/odb.c ---
    @@ -13133,7 +13134,7 @@ static int Otcol(int eid, SQLHDBC *Ocn)
                                 str[j]= '\0';
                             }
                         } else {
    -                        if ( isspace((int)str[j]) || str[j]=='#' )
    --- End diff --
    
    Thanks for your explanation.
    With this change odb will not support comment in the pamfile, so [TRAFODION-2102] is not
a bug is not a bug, and I will close that jira.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message