trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <>
Subject [GitHub] incubator-trafodion pull request #657: [TRAFODION-2159] Unnest correlated su...
Date Wed, 17 Aug 2016 20:20:58 GMT
Github user DaveBirdsall commented on a diff in the pull request:
    --- Diff: core/sql/optimizer/NormRelExpr.cpp ---
    @@ -2404,8 +2412,13 @@ void Join::createAFilterGrandChildIfNeeded(NormWA & normWARef)
       if (doNotUnnest == FALSE)
    -    if (oldRightGrandChild->selectionPred().getReferencedPredicates
    -                                        (outerReferences, nonLocalPreds))
    +    oldRightGrandChild->selectionPred().getReferencedPredicates
    +      (outerReferences, nonLocalPreds) ;
    +    if (nestedAggInSubQ)
    +      subQGby->selectionPred().getReferencedPredicates
    --- End diff --
    Suppose the GROUP BY being unnested has both a WHERE clause and a HAVING clause. Do predicates
for both get picked up here?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message