trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #657: [TRAFODION-2159] Unnest correlated su...
Date Wed, 17 Aug 2016 20:23:06 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/657#discussion_r75199361
  
    --- Diff: core/sql/optimizer/NormRelExpr.cpp ---
    @@ -2404,8 +2412,13 @@ void Join::createAFilterGrandChildIfNeeded(NormWA & normWARef)
       if (doNotUnnest == FALSE)
       {
         nonLocalPreds.clear();
    -    if (oldRightGrandChild->selectionPred().getReferencedPredicates
    -                                        (outerReferences, nonLocalPreds))
    +    oldRightGrandChild->selectionPred().getReferencedPredicates
    +      (outerReferences, nonLocalPreds) ;
    +    if (nestedAggInSubQ)
    +      subQGby->selectionPred().getReferencedPredicates
    +	(outerReferences, nonLocalPreds);
    +
    +    if (!nonLocalPreds.isEmpty())
    --- End diff --
    
    Ah, reading the comments below I think answered my question. Looks like HAVING predicates
are included. (And maybe WHERE predicates don't matter?)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message