trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #660: TRAFODION [2137] Improve metadata acc...
Date Wed, 17 Aug 2016 22:37:53 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/660#discussion_r75220533
  
    --- Diff: core/sql/sqlcomp/PrivMgrPrivileges.cpp ---
    @@ -555,6 +555,90 @@ PrivStatus PrivMgrPrivileges::buildSecurityKeys(
     }
     
     // *****************************************************************************
    +// * Method: getPrivsOnObject                                
    +// *                                                       
    +// * Creates a set of priv descriptors for all user grantees on an object
    +// * Used by Trafodion compiler to store as part of the table descriptor.
    +// *                                                       
    +// *  Parameters:    
    +// *                                                                       
    +// *  <objectType> is the type of object
    +// *  <priv>Descs> is the list of privileges the on the object
    +// *                                                                  
    +// * Returns: PrivStatus                                               
    +// *                                                                  
    +// * STATUS_GOOD: privilege descriptors were built
    +// *           *: unexpected error occurred, see diags.     
    +// *  
    +// *****************************************************************************
    +PrivStatus PrivMgrPrivileges::getPrivsOnObject (
    +  const ComObjectType objectType,
    +  std::vector<PrivMgrDesc> & privDescs )
    +{
    +  PrivStatus retcode = STATUS_GOOD;
    +
    +  if (objectUID_ == 0)
    +  {
    +    PRIVMGR_INTERNAL_ERROR("objectUID is 0 for getPrivRowsForObject()");
    +    return STATUS_ERROR;
    +  }
    +
    +  // generate the list of privileges granted to the object and store in class
    +  if (generateObjectRowList() == STATUS_ERROR)
    +    return STATUS_ERROR;
    +  
    +  // generate the list of privileges granted to the object and store in class
    --- End diff --
    
    should be "to the columns"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message