trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertamarton <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #660: TRAFODION [2137] Improve metadata acc...
Date Thu, 18 Aug 2016 15:41:56 GMT
Github user robertamarton commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/660#discussion_r75333183
  
    --- Diff: core/sql/comexe/ComTdb.h ---
    @@ -1143,6 +1145,33 @@ class ComTdbVirtTableSequenceInfo : public ComTdbVirtTableBase
       Int64                  redefTime;
     };
     
    +
    +// This class describes object and column privileges and if they are grantable 
    +// (WGO) for an object. Privileges are stored as a vector of PrivMgrDesc's, one
    +// per distinct grantee.  
    +//
    +//    PrivMgrDesc:
    +//      grantee - Int32
    +//      objectPrivs - PrivMgrCoreDesc 
    +//      columnPrivs - list of PrivMgrCoreDesc 
    +//    PrivMgrCoreDesc:
    +//      bitmap of granted privileges
    +//      bitmap of associated WGO (with grant option)
    +//      column ordinal (number) set to -1 for object privs
    +class ComTdbVirtTablePrivInfo : public ComTdbVirtTableBase
    +{
    + public:
    +  ComTdbVirtTablePrivInfo()
    +    : ComTdbVirtTableBase()
    +    {
    +      init();
    +    }
    +
    +  virtual Int32 size() { return sizeof(ComTdbVirtTablePrivInfo);}
    +
    +  std::vector<PrivMgrDesc>     *privmgr_desc_list;     
    --- End diff --
    
    I am not sure on all the memory rules and did wonder if I should include a vector class
here. I could convert the std::vector of PrivMgrDesc to an NAList of PrivMgrDescs if that
would be better.   


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message