trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From traflm <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #633: [TRAFODION-2119] DDL warning/error if...
Date Tue, 02 Aug 2016 00:35:13 GMT
GitHub user traflm opened a pull request:

    https://github.com/apache/incubator-trafodion/pull/633

    [TRAFODION-2119] DDL warning/error if using store by on utf8 column

    If store by is used and the column is not set 'not null', there will be an extra null
indicator header. So the generated hbase split by string will contain un-initialized character
and sometime raise warning or error.
    
    The calling to type->minRepresentableValue should pass the buf address that take null
indicator buffer into account, good examples are in:
    -EncodedValue::minMaxValue()
    -ConstValue::ConstValue()
    
    but getMinMaxValue() is wrong. 
    
    Although the calling conversion is not clear, this will be a fix to the issue, there are
other some places to invoke minRepresentatbleValue, so keep the current semantics is good
from my point of view. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/traflm/incubator-trafodion TRAFODION-2119-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafodion/pull/633.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #633
    
----
commit 6ce98ff1cf7a306403845a8d52f3c5f2801c283d
Author: Liu Ming <ovis_poly@sina.com>
Date:   2016-08-02T00:29:45Z

    [TRAFODION-2119] DDL warning/error if using store by on utf8 column

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message