trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anoopsharma00 <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #634: metadata access performance improveme...
Date Tue, 02 Aug 2016 19:49:17 GMT
GitHub user anoopsharma00 opened a pull request:

    https://github.com/apache/incubator-trafodion/pull/634

    metadata access performance improvement for accessing traf objects

    Packed version of descriptor structures is now stored in traf TEXT
    table during various DDL operations.
    During dml, if packed descriptors exist, then they are read and used.
    If they dont exist, then descriptors are generated on the fly.
    
    Descriptor classes are defined in file sqlcat/TrafDDLdesc.h and
    are based off the older desc structures from desc.h.
    These are simplified and class'ified version of the older structures
    and are versioned. Changes to these classes should be done carefully
    by either using filler bytes or versioning them.
    
    2 new cqds, traf_store_object_descriptor and traf_read_object_descriptor,
    are added to control if packed descs should be stored/read.
    These are currently set to OFF by default but are enabled during
    regressions run. Once this feature is tested, these cqds will be turned
    on by default.
    
    In addition, some helper commands have been added to manipulate descrs.
    Syntax:
     alter table t [check|generate|delete|disable|enable] stored descritors
    
    If authorization is enabled, then auth/priv specific info
    is generated on the fly and currently not stored in metadata.
    In a later checkin, these will also be stored in metadata.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/anoopsharma00/incubator-trafodion ansharma_mdperf_br

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafodion/pull/634.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #634
    
----
commit 19c96b1ec830f7b340854b37d8b5e6fea72554fd
Author: Anoop Sharma <anoop.sharma@esgyn.com>
Date:   2016-08-02T19:46:35Z

    metadata access performance improvement for accessing traf objects
    
    Packed version of descriptor structures is now stored in traf TEXT
    table during various DDL operations.
    During dml, if packed descriptors exist, then they are read and used.
    If they dont exist, then descriptors are generated on the fly.
    
    Descriptor classes are defined in file sqlcat/TrafDDLdesc.h and
    are based off the older desc structures from desc.h.
    These are simplified and class'ified version of the older structures
    and are versioned. Changes to these classes should be done carefully
    by either using filler bytes or versioning them.
    
    2 new cqds, traf_store_object_descriptor and traf_read_object_descriptor,
    are added to control if packed descs should be stored/read.
    These are currently set to OFF by default but are enabled during
    regressions run. Once this feature is tested, these cqds will be turned
    on by default.
    
    In addition, some helper commands have been added to manipulate descrs.
    Syntax:
     alter table t [check|generate|delete|disable|enable] stored descritors
    
    If authorization is enabled, then auth/priv specific info
    is generated on the fly and currently not stored in metadata.
    In a later checkin, these will also be stored in metadata.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message