trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zellerh <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #697: [TRAFODION-2218] Memory leak from JVM...
Date Wed, 14 Sep 2016 15:17:36 GMT
Github user zellerh commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/697#discussion_r78770097
  
    --- Diff: core/sql/src/main/java/org/trafodion/sql/udr/LmUDRObjMethodInvoke.java ---
    @@ -68,7 +68,7 @@ static LmUDRObjMethodInvoke makeNewObj(
             return result;
         }
     
    -    public static class ReturnInfo
    +    public class ReturnInfo
    --- End diff --
    
    Yes, what you say in your last sentence is what I'm thinking as well. If a nested class
doesn't need an association with an object of its parent class then it is preferable to make
it static. In this case, I feel that passing a ReturnInfo object across JNI is a bit strange
with an inner class, as we would separate the two related objects.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message