trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zellerh <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #702: optimize using of udf
Date Wed, 14 Sep 2016 16:32:11 GMT
Github user zellerh commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/702#discussion_r78784941
  
    --- Diff: core/sql/src/main/java/org/trafodion/sql/udr/SimpleUDR.java ---
    @@ -0,0 +1,105 @@
    +// @@@ START COPYRIGHT @@@
    +//
    +// Licensed to the Apache Software Foundation (ASF) under one
    +// or more contributor license agreements.  See the NOTICE file
    +// distributed with this work for additional information
    +// regarding copyright ownership.  The ASF licenses this file
    +// to you under the Apache License, Version 2.0 (the
    +// "License"); you may not use this file except in compliance
    +// with the License.  You may obtain a copy of the License at
    +//
    +//   http://www.apache.org/licenses/LICENSE-2.0
    +//
    +// Unless required by applicable law or agreed to in writing,
    +// software distributed under the License is distributed on an
    +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +// KIND, either express or implied.  See the License for the
    +// specific language governing permissions and limitations
    +// under the License.
    +//
    +// @@@ END COPYRIGHT @@@
    +
    +package org.trafodion.sql.udr;
    +import java.util.ArrayList;
    +import java.util.Date;
    +import java.util.List;
    +
    +import org.apache.log4j.Logger;
    +import org.trafodion.sql.udr.TypeInfo.SQLTypeCode;
    +
    +public abstract class SimpleUDR extends UDR {
    +    private static Logger log = Logger.getLogger(SimpleUDR.class.getName());
    +    private List<ColumnInfo> columns = new ArrayList<ColumnInfo>();
    +    UDRInvocationInfo info = null;
    +
    +
    +    public abstract void prepare(UDRInvocationInfo info, UDRPlanInfo plan);
    +
    +    /**
    + *      * recycle the init value
    + *           */
    +    public abstract void close(UDRInvocationInfo info, UDRPlanInfo plan);
    +
    +    /**
    + *      * @throws UDRException
    + *           * 
    + *                */
    +    public abstract void execute(TupleInfo tuple) throws UDRException;
    +
    +    public List<ColumnInfo> getColumns() {
    +        return columns;
    +    }
    +
    +    public int getNumColumns() {
    +        return columns.size();
    +    }
    +
    +    @Override
    +    public final void processData(UDRInvocationInfo info, UDRPlanInfo plan) throws UDRException
{
    +        this.info = info;
    +        TableInfo tblInfo = info.in();
    +        for (int i = 0; i < tblInfo.getNumColumns(); i++) {
    +            columns.add(tblInfo.getColumn(i));
    +        }
    +
    +        prepare(info, plan);
    +
    +        while (getNextRow(info)) {
    +            tblInfo = info.in(0);
    +
    +            execute(tblInfo);
    +        }
    +
    +        close(info, plan);
    +    }
    +
    +    public void emitRow(Object... values) throws UDRException {
    --- End diff --
    
    Nice idea to have such a method, I like it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message