trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From traflm <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #703: [TRAFODION-2208] function support: lo...
Date Thu, 15 Sep 2016 09:52:50 GMT
Github user traflm commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/703#discussion_r78925378
  
    --- Diff: core/sql/exp/exp_math_func.cpp ---
    @@ -348,7 +349,18 @@ ex_expr::exp_return_type ExFunctionMath::eval(char *op_data[],
     	  return ex_expr::EXPR_ERROR;
     	}
           
    -      *(double *)op_data[0] = MathLog10(*(double *)op_data[1], err);
    +      *(double *)op_data[0] = MathLog2(*(double *)op_data[1], err);
    --- End diff --
    
    oops, yes. Sorry about this bug.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message