trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertamarton <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #704: [TRAFODION-1794]: Log authentication ...
Date Wed, 14 Sep 2016 17:28:08 GMT
GitHub user robertamarton opened a pull request:

    https://github.com/apache/incubator-trafodion/pull/704

    [TRAFODION-1794]: Log authentication Information

    Added code to log LDAP connection errors into the associated log4cxx file.
    For authentications that occur in mxosrvr, events are logged into the master
    executor log.  For standalone utilities such as ldapcheck, events are logged
    into a separate file with names: dbsecurity_<hostname>_<pid>.log.
    
    This code was donated to the Trafodion team and it originally logged events
    into a repository table and/or a stdout log.  This change will log
    authentication details into the standard log4cxx logs.  Session information is
    being logged into repository tables which describe connection attributes but
    detailed LDAP errors will be only put in the logs.
    
    The ldapcheck utility has been instrumented to log errors in the logs directory
    previously, errors were not logged.  This will be needed when TRAFODION-1787
    is implemented.
    
    The files authEvent.h and authEvents.cpp replace existing files called
    ld_globals.h and ld_port.cpp.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/robertamarton/incubator-trafodion trafodion-1794

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafodion/pull/704.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #704
    
----
commit 7bab83873b519ec8be7d4ce67a2aea74889c6081
Author: Roberta Marton <rmarton@edev07.esgyn.local>
Date:   2016-09-14T17:24:55Z

    [TRAFODION-1794]: Log authentication Information
    
    Added code to log LDAP connection errors into the associated log4cxx file.
    For authentications that occur in mxosrvr, events are logged into the master
    executor log.  For standalone utilities such as ldapcheck, events are logged
    into a separate file with names: dbsecurity_<hostname>_<pid>.log.
    
    This code was donated to the Trafodion team and it originally logged events
    into a repository table and/or a stdout log.  This change will log
    authentication details into the standard log4cxx logs.  Session information is
    being logged into repository tables which describe connection attributes but
    detailed LDAP errors will be only put in the logs.
    
    The ldapcheck utility has been instrumented to log errors in the logs directory
    previously, errors were not logged.  This will be needed when TRAFODION-1787
    is implemented.
    
    The files authEvent.h and authEvents.cpp replace existing files called
    ld_globals.h and ld_port.cpp.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message