trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anoopsharma00 <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #708: jira TRAFODION-2181 Enable incompatib...
Date Thu, 15 Sep 2016 19:12:48 GMT
GitHub user anoopsharma00 opened a pull request:

    https://github.com/apache/incubator-trafodion/pull/708

    jira TRAFODION-2181 Enable incompatible operations in sql queries

    Incompatible operations are defined as opers between datatypes
    that belong to different categories.
    For ex, comparison of numeric to string. In these cases, one side
    need to be converted to the other before doing the comparison.
    
    This checkin enables following incompatible operations:
      -- assignment between incompatible datatypes
      -- conversion between incompatible datatypes
      -- comparison between incompatible datatypes
      -- arith between incompatible datatypes
      -- string operation on incompatible datatypes
    
    The infrastructure changes to support was added as part of
    a previous jira. Dev regressions have since then been running with
    incomp opers enabled.
    
    These operations are on by default now and some operations that
    previously failed will no longer fail.
    
    Changes are been tested as much as possible and any issues that
    show up during runs will be fixed as a regular bug fix.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/anoopsharma00/incubator-trafodion ansharma_trafr21_incomp

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafodion/pull/708.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #708
    
----
commit 4fea08efc9013eb62f766286afe77c6246a4c472
Author: Anoop Sharma <anoop.sharma@esgyn.com>
Date:   2016-09-15T19:11:15Z

    jira TRAFODION-2181 Enable incompatible operations in sql queries
    
    Incompatible operations are defined as opers between datatypes
    that belong to different categories.
    For ex, comparison of numeric to string. In these cases, one side
    need to be converted to the other before doing the comparison.
    
    This checkin enables following incompatible operations:
      -- assignment between incompatible datatypes
      -- conversion between incompatible datatypes
      -- comparison between incompatible datatypes
      -- arith between incompatible datatypes
      -- string operation on incompatible datatypes
    
    The infrastructure changes to support was added as part of
    a previous jira. Dev regressions have since then been running with
    incomp opers enabled.
    
    These operations are on by default now and some operations that
    previously failed will no longer fail.
    
    Changes are been tested as much as possible and any issues that
    show up during runs will be fixed as a regular bug fix.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message