From codereview-return-3329-apmail-trafodion-codereview-archive=trafodion.apache.org@trafodion.incubator.apache.org Wed Sep 14 15:30:14 2016 Return-Path: X-Original-To: apmail-trafodion-codereview-archive@minotaur.apache.org Delivered-To: apmail-trafodion-codereview-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 438B81904A for ; Wed, 14 Sep 2016 15:30:14 +0000 (UTC) Received: (qmail 26294 invoked by uid 500); 14 Sep 2016 15:30:14 -0000 Delivered-To: apmail-trafodion-codereview-archive@trafodion.apache.org Received: (qmail 26260 invoked by uid 500); 14 Sep 2016 15:30:14 -0000 Mailing-List: contact codereview-help@trafodion.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: codereview@trafodion.incubator.apache.org Delivered-To: mailing list codereview@trafodion.incubator.apache.org Received: (qmail 26249 invoked by uid 99); 14 Sep 2016 15:30:13 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 14 Sep 2016 15:30:13 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 75FA1C6D90 for ; Wed, 14 Sep 2016 15:30:13 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -5.144 X-Spam-Level: X-Spam-Status: No, score=-5.144 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.124] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id G-SM2GLFOWNy for ; Wed, 14 Sep 2016 15:30:08 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 607175FB37 for ; Wed, 14 Sep 2016 15:30:07 +0000 (UTC) Received: (qmail 26199 invoked by uid 99); 14 Sep 2016 15:30:06 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 14 Sep 2016 15:30:06 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 793BDE01BA; Wed, 14 Sep 2016 15:30:06 +0000 (UTC) From: sureshsubbiah To: codereview@trafodion.incubator.apache.org Reply-To: codereview@trafodion.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-trafodion pull request #697: [TRAFODION-2218] Memory leak from JVM... Content-Type: text/plain Message-Id: <20160914153006.793BDE01BA@git1-us-west.apache.org> Date: Wed, 14 Sep 2016 15:30:06 +0000 (UTC) Github user sureshsubbiah commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/697#discussion_r78772888 --- Diff: core/sql/langman/LmRoutineJavaObj.cpp --- @@ -192,6 +192,7 @@ LmResult LmRoutineJavaObj::invokeRoutineMethod( (*emitRowPtr_)(NULL,0,&qs); } } + jni->DeleteLocalRef(jniResult); --- End diff -- Sorry for not noticing this. It does seem dangerous to use data members from deleted objects. I will work on coding a fix and push another commit for this PR. Previously we know for certain that the ReturnInfo object on the Java side was never GCed. It was "live" always. So we were not exposed to this problem. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---