From codereview-return-3345-apmail-trafodion-codereview-archive=trafodion.apache.org@trafodion.incubator.apache.org Thu Sep 15 09:52:54 2016 Return-Path: X-Original-To: apmail-trafodion-codereview-archive@minotaur.apache.org Delivered-To: apmail-trafodion-codereview-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C685119629 for ; Thu, 15 Sep 2016 09:52:54 +0000 (UTC) Received: (qmail 40002 invoked by uid 500); 15 Sep 2016 09:52:54 -0000 Delivered-To: apmail-trafodion-codereview-archive@trafodion.apache.org Received: (qmail 39968 invoked by uid 500); 15 Sep 2016 09:52:54 -0000 Mailing-List: contact codereview-help@trafodion.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: codereview@trafodion.incubator.apache.org Delivered-To: mailing list codereview@trafodion.incubator.apache.org Received: (qmail 39848 invoked by uid 99); 15 Sep 2016 09:52:54 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Sep 2016 09:52:54 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 194CD1A7B00 for ; Thu, 15 Sep 2016 09:52:54 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -5.446 X-Spam-Level: X-Spam-Status: No, score=-5.446 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.426] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id ESbqqQH1h3qT for ; Thu, 15 Sep 2016 09:52:53 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id A647F60D10 for ; Thu, 15 Sep 2016 09:52:51 +0000 (UTC) Received: (qmail 39676 invoked by uid 99); 15 Sep 2016 09:52:50 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Sep 2016 09:52:50 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 9AEC0E0B49; Thu, 15 Sep 2016 09:52:50 +0000 (UTC) From: traflm To: codereview@trafodion.incubator.apache.org Reply-To: codereview@trafodion.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-trafodion pull request #703: [TRAFODION-2208] function support: lo... Content-Type: text/plain Message-Id: <20160915095250.9AEC0E0B49@git1-us-west.apache.org> Date: Thu, 15 Sep 2016 09:52:50 +0000 (UTC) Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/703#discussion_r78925378 --- Diff: core/sql/exp/exp_math_func.cpp --- @@ -348,7 +349,18 @@ ex_expr::exp_return_type ExFunctionMath::eval(char *op_data[], return ex_expr::EXPR_ERROR; } - *(double *)op_data[0] = MathLog10(*(double *)op_data[1], err); + *(double *)op_data[0] = MathLog2(*(double *)op_data[1], err); --- End diff -- oops, yes. Sorry about this bug. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---