trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sureshsubbiah <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #806: TRAFODION-2330 Using trafci, a select...
Date Tue, 01 Nov 2016 14:13:47 GMT
Github user sureshsubbiah commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/806#discussion_r85935717
  
    --- Diff: core/sql/arkcmp/CmpContext.cpp ---
    @@ -1157,4 +1157,16 @@ void CmpContext::resetLogmxEventSqlText()
        delete sqlTextBuf_ ;
        sqlTextBuf_ = NULL ;
     }
    +
    +void CmpContext::clearAllCaches()
    +{
    +   qcache_->makeEmpty();
    --- End diff --
    
    The constructor for CmpContext seems to initialize histogramCache_ the same as qcache_.
Is it possible qcache_ can be NULL at some point? It may be safer to guard it, this is a really
minor nit to be handled later if necessary.
    
    There is one more cache, optPCodeCache_ . Now this cache may not cause any priv violations
I suppose. So a comment later here may be all we need, that PCode cache is not addressed by
this method.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message