trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From svarnau <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #807: [TRAFODION-1839] Trafodion Installer ...
Date Tue, 01 Nov 2016 22:25:38 GMT
Github user svarnau commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/807#discussion_r86027515
  
    --- Diff: install/python-installer/common.py ---
    @@ -0,0 +1,479 @@
    +#!/usr/bin/env python
    +
    +# @@@ START COPYRIGHT @@@
    +#
    +# Licensed to the Apache Software Foundation (ASF) under one
    +# or more contributor license agreements.  See the NOTICE file
    +# distributed with this work for additional information
    +# regarding copyright ownership.  The ASF licenses this file
    +# to you under the Apache License, Version 2.0 (the
    +# "License"); you may not use this file except in compliance
    +# with the License.  You may obtain a copy of the License at
    +#
    +#   http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing,
    +# software distributed under the License is distributed on an
    +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +# KIND, either express or implied.  See the License for the
    +# specific language governing permissions and limitations
    +# under the License.
    +#
    +# @@@ END COPYRIGHT @@@
    +
    +### The common functions ###
    +
    +import os
    +import pty
    +import sys
    +import json
    +import re
    +import time
    +import base64
    +import subprocess
    +import logging
    +try:
    +    import xml.etree.cElementTree as ET
    +except ImportError:
    +    import xml.etree.ElementTree as ET
    +from ConfigParser import ConfigParser
    +from collections import defaultdict
    +
    +__VERSION__ = 'v1.0.0'
    +INSTALLER_LOC = sys.path[0]
    +
    +USER_PROMPT_FILE = INSTALLER_LOC + '/prompt.json'
    +SCRCFG_FILE = INSTALLER_LOC + '/script.json'
    +VERSION_FILE = INSTALLER_LOC + '/version.json'
    +MODCFG_FILE = INSTALLER_LOC + '/mod_cfgs.json'
    +
    +DBCFG_FILE = INSTALLER_LOC + '/db_config'
    +DBCFG_TMP_FILE = INSTALLER_LOC + '/.db_config_temp'
    +
    +TMP_DIR = '/tmp/.install'
    +MARK = '[ERR]'
    --- End diff --
    
    .install is a very generic name. It may possibly be used for other things and hence not
secured properly, etc.
    Maybe something like /tmp/trafodion_install_temp would be better.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message