trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From traflm <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #810: [TRAFODION-2293] remove minor version...
Date Thu, 03 Nov 2016 01:24:59 GMT
Github user traflm commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/810#discussion_r86275214
  
    --- Diff: core/sqf/sql/scripts/install_local_hadoop ---
    @@ -1554,7 +1554,7 @@ echo "$MY_LOCAL_SW_DIST/${HBASE_TAR}"
           org.apache.hadoop.hbase.security.visibility.VisibilityController"
       fi
     
    -  if [[ "$HBASE_DISTRO" != "APACHE1.2" || "$HBASE_DISTRO" != "CDH5.7"]]; then 
    +  if [[ "$HBASE_DISTRO" != "APACHE1.2" && "$HBASE_DISTRO" != "CDH5.7"]]; then

    --- End diff --
    
    not able to determine if this work correctly or not, @mashengchen , please describe the
UT you did after this change.
    Since this only change '||' to '&&', but from what others reported, there are
other issues like 'space' and the local_hadoop directory. So it is a must to run it yourself
before I can approve this. 
    So please describe how you did the UT.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message