trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #813: [TRAFODION-2229] add Hashing function...
Date Thu, 03 Nov 2016 17:57:31 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/813#discussion_r86403676
  
    --- Diff: core/sql/exp/exp_function.cpp ---
    @@ -40,6 +40,10 @@
     
     
     #include <math.h>
    +#include <zlib.h>
    +#include "openssl/md5.h"
    --- End diff --
    
    I'm wondering why this isn't <openssl/md5.h>. Seems like one would have to copy
the md5.h file into the source tree somewhere for this to compile cleanly. Maybe you meant
to use angle brackets instead of quotes?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message