trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #813: [TRAFODION-2229] add Hashing function...
Date Thu, 03 Nov 2016 17:57:31 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/813#discussion_r86403186
  
    --- Diff: core/sql/common/OperTypeEnum.h ---
    @@ -787,6 +787,11 @@ enum OperatorTypeEnum {
                             ITM_ISIPV6 = 2631,
                             ITM_INET_ATON = 2632,
                             ITM_INET_NTOA = 2633,
    +                        ITM_CRC32     = 2634,
    +                        ITM_MD5       = 2635,
    +                        ITM_SHA1      = 2636,
    +                        ITM_SHA2      = 2637,
    +                        ITM_SHA       = 2638,
    --- End diff --
    
    ITM_SHA is never used. Looking at the parser changes, it appears that SHA is simply a
syntactic sugar meaning the same as SHA1, so the difference between SHA and SHA1 disappears
after parsing. So ITM_SHA is not needed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message