trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #815: [TRAFODION-2326] TopN sort reuse of r...
Date Thu, 03 Nov 2016 18:25:46 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/815#discussion_r86411525
  
    --- Diff: core/sql/executor/ex_sort.h ---
    @@ -356,4 +363,119 @@ class ExSortFromTopPrivateState : public ex_tcb_private_state
       ~ExSortFromTopPrivateState();       // destructor
     };
     
    +class ExSortBufferPool : public NABasicObject
    --- End diff --
    
    A more object-oriented way to do this is to create a class hierarchy, with ExSortBufferPool
as the abstract base class, and two specializations, one for simple buffers and the other
for SQL buffers. Then all your methods are virtual and you get rid of all the "if (sqlBufferPool_)"
checks. The code will be slightly more efficient too though probably not significantly so.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message