trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #815: [TRAFODION-2326] TopN sort reuse of r...
Date Thu, 03 Nov 2016 18:25:46 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/815#discussion_r86410177
  
    --- Diff: core/sql/executor/ex_sort.cpp ---
    @@ -330,21 +364,39 @@ ExSortTcb::~ExSortTcb()
        nfDiags_ = NULL;
       
       freeResources();
    -  
    -  if(pool_)
    -    delete pool_;
    +
     };
       
     ////////////////////////////////////////////////////////////////////////
     // Free Resources
     //
     void ExSortTcb::freeResources()
     {
    -  if (sortPool_)
    +  if (partialSortPool_)
    +  {
    +    delete partialSortPool_;
    +    partialSortPool_ = NULL;
    +  }
    +  if (regularSortPool_)
    +  {
    +    delete regularSortPool_;
    +    regularSortPool_ = NULL;
    +  }
    +  if (topNSortPool_)
    +  {
    +    delete topNSortPool_;
    +    topNSortPool_ = NULL;
    +  }
    +  if (sortPool_ && (sortPool_ != receivePool_))
    --- End diff --
    
    What if sortPool_ is not null and  sortPool_ == receivePool_? Shouldn't we set it to NULL
in this case (without doing a delete)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message