trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From arvind-narain <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #799: [TRAFODION-2308]JDBC T4 support read ...
Date Thu, 03 Nov 2016 20:02:47 GMT
Github user arvind-narain commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/799#discussion_r86427334
  
    --- Diff: core/conn/odbc/src/odbc/nsksrvr/Interface/odbcs_srvr_res.cpp ---
    @@ -642,6 +642,41 @@ odbc_SQLSrvr_EndTransaction_ts_res_(
     
     } // odbc_SQLSrvr_EndTransaction_ts_res_()
     
    +CEE_status
    +odbc_SQLSrvr_ExtractLob_ts_res_(
    +    /* In   */ CEE_tag_def    objtag_
    +  , /* In   */ const CEE_handle_def *call_id_
    +  , /* In   */ const struct odbc_SQLsrvr_ExtractLob_exc_ *exception_
    +  , /* In   */ IDL_long_long  lobDataLen
    +  , /* In   */ IDL_char       *lobDataValue
    +  )
    +{
    +    CInterface* pnode = (CInterface *)objtag_;
    +
    +    CEE_status sts = CEE_SUCCESS;
    +
    +    IDL_short error;
    +    CEERCV_IOMessage_reply_seq_ reply;
    +
    +    char * buffer = NULL;
    +    UInt32 message_length = 0;
    +
    +    odbc_SQLsrvr_ExtractLob_param_res_(
    --- End diff --
    
    If odbc_SQLsrvr_ExtractLob_param_res_ does return error ( CEE_ALLOCFAIL - previous comment
) then store the return status in sts here and check for the same.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message