trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From traflm <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #813: [TRAFODION-2229] add Hashing function...
Date Fri, 04 Nov 2016 01:39:54 GMT
Github user traflm commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/813#discussion_r86476506
  
    --- Diff: core/sql/parser/sqlparser.y ---
    @@ -9671,6 +9676,62 @@ misc_function :
     				  $$ = $2;
     				}
     
    +     | TOK_SHA  '(' value_expression ')'
    +                {
    +                    $$ = new (PARSERHEAP())
    +                    BuiltinFunction(ITM_SHA1,
    +                            CmpCommon::statementHeap(),
    +                            1, $3);
    +                }
    +     | TOK_SHA1  '(' value_expression ')'
    +                {
    +                    $$ = new (PARSERHEAP())
    +                    BuiltinFunction(ITM_SHA1,
    +                            CmpCommon::statementHeap(),
    +                            1, $3);
    +                }
    +
    +     | TOK_SHA2 '(' value_expression ')'
    +                {
    +                    $$ = new (PARSERHEAP())
    +                    BuiltinFunction(ITM_SHA2,
    +                            CmpCommon::statementHeap(),
    +                            1, $3);
    +                }
    +
    +     | TOK_MD5 '(' value_expression ')'
    +                {
    +                    $$ = new (PARSERHEAP())
    +                    BuiltinFunction(ITM_MD5,
    +                            CmpCommon::statementHeap(),
    +                            1, $3);
    +                }
    +
    +     | TOK_CRC32 '(' value_expression ')'
    +                {
    +                    $$ = new (PARSERHEAP())
    +                    BuiltinFunction(ITM_CRC32,
    +                            CmpCommon::statementHeap(),
    +                            1, $3);
    +                }
    +
    +
    +     | TOK_SHA1 '(' value_expression ')'
    --- End diff --
    
    thanks Dave for catching this, this is a bug, will fix.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message