trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From prashanth-vasudev <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #815: [TRAFODION-2326] TopN sort reuse of r...
Date Fri, 04 Nov 2016 07:22:48 GMT
Github user prashanth-vasudev commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/815#discussion_r86497624
  
    --- Diff: core/sql/executor/ex_sort.cpp ---
    @@ -183,6 +212,11 @@ ExSortTcb::ExSortTcb(const ExSortTdb & sort_tdb,
       processedInputs_ = qparent_.down->getTailIndex();
       workAtp_ = allocateAtp(sort_tdb.workCriDesc_, space);
       workAtp_->getTupp(2) = new(space) tupp_descriptor();
    +  
    +  //buffer pools are allocated in SORT_PREP work phase.
    +  topNSortPool_ = NULL;
    +  regularSortPool_ = NULL;
    +  partialSortPool_ = NULL;
    --- End diff --
    
    I will make this change. ReceivePool_ and sortPool_ are assigned a value always during
sort prep step.  But assigning to null is safe in case of error scenarios.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message