trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zellerh <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #795: [TRAFODION-2270] support ORDER BY in ...
Date Tue, 08 Nov 2016 01:38:27 GMT
Github user zellerh commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/795#discussion_r86908390
  
    --- Diff: core/sql/optimizer/RelGrby.h ---
    @@ -552,7 +560,9 @@ class GroupByAgg : public RelExpr
       // ---------------------------------------------------------------------
       ItemExpr    * groupExprTree_;
       ValueIdSet  groupExpr_;
    -
    +  
    +  ItemExpr  * extraGrpOrderby_;
    +  ValueIdList  extraOrderExpr_;
    --- End diff --
    
    Anoop added the rollup feature recently, see https://github.com/apache/incubator-trafodion/pull/733.
This also introduces an extra order by expression for a groupby. Maybe you and Anoop can decide
whether you want to combine your code, for example by using this extra order for the ROLLUP
groupby as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message