trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zellerh <>
Subject [GitHub] incubator-trafodion pull request #795: [TRAFODION-2270] support ORDER BY in ...
Date Tue, 08 Nov 2016 01:38:27 GMT
Github user zellerh commented on a diff in the pull request:
    --- Diff: core/sql/optimizer/OptPhysRelExpr.cpp ---
    @@ -11856,6 +11868,7 @@ SortGroupBy::synthPhysicalProperty(const Context* myContext,
    +      //PhysicalProperty(((isRollup() ||NOT extraOrderExpr().isEmpty()) ? ValueIdList()
: sppOfChild->getSortKey()),
    --- End diff --
    Could you remove this dead code?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message