trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From traflm <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #795: [TRAFODION-2270] support ORDER BY in ...
Date Tue, 08 Nov 2016 02:03:05 GMT
Github user traflm commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/795#discussion_r86910814
  
    --- Diff: core/sql/optimizer/RelGrby.h ---
    @@ -152,6 +154,9 @@ class GroupByAgg : public RelExpr
       inline void setGroupExpr(ValueIdSet &expr) { groupExpr_ = expr;}
       inline void addGroupExpr(ValueIdSet &expr) { groupExpr_ += expr;}
     
    +  inline ValueIdList & extraOrderExpr() { return extraOrderExpr_; }
    --- End diff --
    
    Yes, it is not a good practice. I need this since this valueID list will be populated
(write) by convertToValueIdList(). Maybe I can rename this to extraOrderExprWritable(), So
the extraOrderExpr() will not be accidentally written.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message