trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #814: [TRAFODION-2331] UPD STATS sometimes ...
Date Thu, 03 Nov 2016 16:50:54 GMT
GitHub user DaveBirdsall opened a pull request:

    https://github.com/apache/incubator-trafodion/pull/814

    [TRAFODION-2331] UPD STATS sometimes fails silently after some other …

    …failure
    
    There are three changes in this check-in:
    
    1. UPDATE STATISTICS does a ROLLBACK after detecting a SQL error. Sometimes the ROLLBACK
fails, because the Executor has already rolled back the transaction. This caused UPDATE STATISTICS
to get confused about transaction state. This has been fixed; now after an error on ROLLBACK,
UPDATE STATISTICS simply checks to see if a transaction is still active, and if not, just
ignores the error.
    
    2. When executing DDL statements, UPDATE STATISTICS tries to start a transaction. If it
is confused about transaction state (as in item 1 above), it thinks this attempt to start
a transaction has failed. In that particular case, no error was being reported. This has been
fixed.
    
    3. Some obsolete code that used static SQL for BEGIN WORK, COMMIT and ROLLBACK has been
removed.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DaveBirdsall/incubator-trafodion SampleTableBug

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafodion/pull/814.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #814
    
----
commit 9e37d9c22c74daee32399dac42f84c43f7141c5e
Author: Dave Birdsall <dbirdsall@apache.org>
Date:   2016-11-03T16:46:05Z

    [TRAFODION-2331] UPD STATS sometimes fails silently after some other failure

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message