trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ryzuo <>
Subject [GitHub] incubator-trafodion pull request #853: [TRAFODION-1262]ODBC:Varchar col oper...
Date Thu, 01 Dec 2016 01:57:35 GMT
Github user ryzuo commented on a diff in the pull request:
    --- Diff: core/conn/unixodbc/odbc/odbcclient/unixcli/cli/cdesc.cpp ---
    @@ -595,9 +597,19 @@ unsigned long CDescRec::setDescRec(short DescMode, SQLItemDesc_def
     		if (m_SQLCharset == SQLCHARSETCODE_UCS2)
    -			m_SQLOctetLength = SQLItemDesc->maxLen+4;
    +		{
    +			if(SQLItemDesc->maxLen > 0x7fff)
    --- End diff --
    Could you please replace all 0x7fff to SHRT_MAX? We should make the semantic be clear,
as well MXOSRVR is doing so, make them consistent

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message