trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ryzuo <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #853: [TRAFODION-1262]ODBC:Varchar col oper...
Date Thu, 01 Dec 2016 01:57:35 GMT
Github user ryzuo commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/853#discussion_r90182609
  
    --- Diff: win-odbc64/odbcclient/drvr35/ctosqlconv.cpp ---
    @@ -284,7 +284,12 @@ unsigned long ODBC::ConvertCToSQL(SQLINTEGER	ODBCAppVersion,
     	case SQL_VARCHAR:
     	case SQL_LONGVARCHAR:
     	case SQL_WVARCHAR:
    -		Offset = sizeof(USHORT);			//Note there is no break, I want it to fall thru
    +		if (targetPrecision > 0x7fff){
    --- End diff --
    
    0x7fff -> SHRT_MAX


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message