trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rwbzx <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #871: [TRAFODION-2375]ODBC:SQLGetDiagRec re...
Date Thu, 08 Dec 2016 06:19:10 GMT
Github user rwbzx commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/871#discussion_r91451478
  
    --- Diff: win-odbc64/odbcclient/drvr35/cdiag.cpp ---
    @@ -389,8 +389,8 @@ SQLRETURN CDiagRec::GetDiagRec(SQLSMALLINT	RecNumber,
     					translateLengthMax/2, (int *)&translateLength, (char *)errorMsg)) != SQL_SUCCESS
)
     				rc = SQL_SUCCESS_WITH_INFO; //ERROR;
     
    -			strLen = translateLength; 
    -			((wchar_t *)MessageText)[strLen] = L'\0' ; 
    +			((wchar_t *)MessageText)[translateLength] = L'\0';
    +			strLen = tmpStrLen;
    --- End diff --
    
    Yes indeed, the logic is added in latest commit. Thanks for the tips. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message