trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #876: [Trafodion 2351] Bulk load with log e...
Date Tue, 13 Dec 2016 22:38:14 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/876#discussion_r92283036
  
    --- Diff: core/sql/executor/ExHbaseAccess.cpp ---
    @@ -3033,14 +3033,23 @@ void ExHbaseAccessTcb::setRowID(char *rowId, Lng32 rowIdLen)
        memcpy(rowID_.val, rowId, rowIdLen);
     }
     
    -void ExHbaseAccessTcb::buildLoggingPath(
    -                             const char * loggingLocation,
    -                             char * logId,
    -                             const char * tableName,
    +void ExHbaseAccessTcb::buildLoggingFileName(
    +                             const char * currCmdLoggingLocation,
    +                             const char *tableName,
                                  const char * loggingFileNamePrefix,
                                  Lng32 instId,
                                  char * loggingFileName)
     {
    +  sprintf(loggingFileName, "%s/%s_%s_%d",
    --- End diff --
    
    How do we know loggingFileName is big enough to store the result?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message