trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #878: TRAFODION-1586 Support for ext Traf t...
Date Thu, 15 Dec 2016 22:55:04 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/878#discussion_r92717803
  
    --- Diff: core/sql/sqlcomp/CmpSeabaseDDLindex.cpp ---
    @@ -518,20 +521,13 @@ void CmpSeabaseDDL::createSeabaseIndex( StmtDDLCreateIndex * createIndexNode,
     
       ActiveSchemaDB()->getNATableDB()->useCache();
     
    -  // save the current parserflags setting
    -  ULng32 savedParserFlags = Get_SqlParser_Flags (0xFFFFFFFF);
    -  Set_SqlParser_Flags(ALLOW_VOLATILE_SCHEMA_IN_TABLE_NAME);
    -
       BindWA bindWA(ActiveSchemaDB(), CmpCommon::context(), FALSE/*inDDL*/);
       CorrName cn(tableName.getObjectNamePart().getInternalName(),
     	      STMTHEAP,
     	      btSchemaNamePart,
     	      btCatalogNamePart);
     
    -  NATable *naTable = bindWA.getNATable(cn); 
    -
    -  // Save parser flags settings so they can be restored later
    -  Set_SqlParser_Flags (savedParserFlags);
    --- End diff --
    
    Glad you took this out, as this code is incorrect. (It should have used Assign_SqlParser_Flags
at line 534.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message