trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From traflm <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #879: [TRAFODION-2211] trafci can use histo...
Date Fri, 16 Dec 2016 07:39:25 GMT
Github user traflm commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/879#discussion_r92764647
  
    --- Diff: core/conn/trafci/src/main/java/org/trafodion/ci/ConsoleReader.java ---
    @@ -172,7 +176,8 @@ public String readLine() throws UnsupportedEncodingException, UserInterruption,
     
    --- End diff --
    
    This will remove Ctrl-C signal handler, did you test Ctrl-C in trafci? It should do a
'cancel query' if I remember it correctly. Anyway, you should make sure Ctrl-C has same behavior
as before, should not be broken by this change. 
    I am not sure, need to check the trafci manual, but wondering if you have tested it or
not? Since you comments out the signal handler.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message