trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sureshsubbiah <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #882: TMUDF fixes and related changes
Date Thu, 22 Dec 2016 15:00:59 GMT
Github user sureshsubbiah commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/882#discussion_r93637494
  
    --- Diff: core/sql/generator/LmExpr.cpp ---
    @@ -362,7 +362,7 @@ LmExprResult CreateLmOutputExpr(const NAType &formalType,
     // specified type t to be converted to/from C strings. The only 
     // SQL types that do not need to be converted to C strings are:
     // 
    -//  INT, SMALLINT, LARGEINT, FLOAT, REAL, DOUBLE PRECISION
    +//  INT, SMALLINT, LARGEINT, FLOAT, REAL, DOUBLE PRECISION, BOOLEAN
    --- End diff --
    
    Does Tinyint belong to this set of types? I suppose the answer is No, but thought it safer
to check.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message