trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From selvaganesang <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #885: [TRAFODION-2414] enhance 8616 commit ...
Date Thu, 22 Dec 2016 18:25:30 GMT
Github user selvaganesang commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/885#discussion_r93671479
  
    --- Diff: core/sqf/inc/cextdecs/cextdecs.h ---
    @@ -289,6 +289,10 @@ _declspec(dllimport) short   DNUMOUT
     
     _declspec(dllimport) short   ENDTRANSACTION();
     
    +//errStr is allocated if errlen is not zero. Caller must deallocate errStr.
    +//Rest of functionality same as ENDTRANSACTION();
    +_declspec(dllimport) short   ENDTRANSACTION_ERR(char *&errStr, int &errlen);
    --- End diff --
    
    This would mean that the errStr is allocated by the TM functions using its own heap management
scheme or the system memory. The caller wouldn't be aware of how to deallocate if it is anything
other than system memory


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message