trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mkby <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #869: [TRAFODION-2388] there should be only...
Date Tue, 06 Dec 2016 15:59:03 GMT
GitHub user mkby opened a pull request:

    https://github.com/apache/incubator-trafodion/pull/869

    [TRAFODION-2388] there should be only one ENV for Trafodion's root directory instead of
many.

    convert $SQ_ROOT, $SQ_HOME, $MY_SQROOT into one variable $MY_SQROOT.
    
    There're too many files using $MY_SQROOT, I'm afraid to bring some unknown issues, so
not changing the name to $TRAF_ROOT. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mkby/incubator-trafodion master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafodion/pull/869.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #869
    
----
commit fbb465ae1a12c1457f19e6a80f39dc4c9fc3b129
Author: Eason <hfutmkby@gmail.com>
Date:   2016-12-06T15:48:05Z

    [TRAFODION-2388] there should be only one ENV for Trafodion's root directory instead of
many.

commit 971df7a4ef2b932339e8013691c7e3212f1d015e
Author: Eason <hfutmkby@gmail.com>
Date:   2016-12-06T15:52:13Z

    remove duplicate MY_SQROOT in sqenvcom.sh

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message