trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rwbzx <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #871: [TRAFODION-2375]ODBC:SQLGetDiagRec re...
Date Wed, 07 Dec 2016 07:07:38 GMT
GitHub user rwbzx opened a pull request:

    https://github.com/apache/incubator-trafodion/pull/871

    [TRAFODION-2375]ODBC:SQLGetDiagRec return wrong msg length when data truncate

    Acoording to ODBC reference, in function SQLGetDiagRec,  param _TextLengthPtr_  should
point to a buffer in which to return the total number of characters, but it returns number
of truncated characters when param _BufferLength_ is smaller than character number of error
message text.
    Thus, modifications are made relating to win/unix odbc driver code as following:
    Unix ODBC: if truncation occurs, return SQL_SUCCESS_WITH_INFO, and set variable strLen
as total number of error message text whenever data is truncated.
    Windows ODBC: set variable strLen as total number of error message text whenever data
is truncated.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rwbzx/incubator-trafodion TRAFODION-2375

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafodion/pull/871.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #871
    
----
commit 8c465fdf282f8083f5066ccfa095ce157a3790b3
Author: rwbzx <xiang.zhang@esgyn.cn>
Date:   2016-12-07T06:46:32Z

    [TRAFODION-2375]SQLGetDiagRec return wrong msg len
    win/unix ODBC:SQLGetDiagRec return wrong len value when data truncate

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message