trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zellerh <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #882: TMUDF fixes and related changes
Date Tue, 20 Dec 2016 22:53:32 GMT
GitHub user zellerh opened a pull request:

    https://github.com/apache/incubator-trafodion/pull/882

    TMUDF fixes and related changes

    This PR has fixes for 5 JIRAs in a set of 4 commits (sorry, two of the fixes had overlaps,
so I bundled them into a single commit). It may be easier to review each commit individually,
since they are logically independent.
    
    **Commit 1:**
    
    [TRAFODION-2382] No plan produced when joining two TMUDFs
    
    A simple join query resulted in no plan. One of the reasons is
    the way we handle operator types for TMUDFs. Changed this so that
    the operator type indicates the arity of the operator.
    
    **Commit 2:**
    
    [TRAFODION-2399] Syntax error when loading from salted table
    
    This was caused by methods to generate an SQL string literal
    from a constant value. In some cases it repeated the character
    set name introducer.
    
    **Commit 3:**
    
    [TRAFODION-2382] Support tinyint and boolean in tmudfs
    
    Adding support for these new data types in TMUDFs.
    
    - core/sql/generator/LmExpr.cpp
    - core/sql/optimizer/UdfDllInteraction.cpp
    - core/sql/sqludr/sqludr.cpp
    - core/sql/sqludr/sqludr.h
    - core/sql/src/main/java/org/trafodion/sql/udr/TupleInfo.java
    - core/sql/src/main/java/org/trafodion/sql/udr/TypeInfo.java
    - core/sql/src/main/java/org/trafodion/sql/udr/UDRInvocationInfo.java
    - core/sql/regress/udr/TEST001
    - core/sql/regress/udr/EXPECTED001
    
    TRAFODION-2392 avoid costly sort in reducer TMUDFs
    
    Add a REDUCER_NC function type. The only difference is in the
    createContextForAChild function, where we don't generate a required
    arrangement for UDFs of this type.
    
    - core/sql/optimizer/OptPhysRelExpr.cpp
    - core/sql/sqludr/sqludr.cpp
    - core/sql/sqludr/sqludr.h
    - core/sql/src/main/java/org/trafodion/sql/udr/UDR.java
    - core/sql/src/main/java/org/trafodion/sql/udr/UDRInvocationInfo.java
    
    Misc changes, not related to a JIRA:
    
    - core/sql/regress/compGeneral/EXPECTED071
    - core/sql/regress/compGeneral/TEST071
    
    **Commit 4:**
    
    [TRAFODION-2400] wrong results for passthru cols
    
    Wrong results were returned for passthru columns in TMUDFs
    when we had equal predicates on the source table. This was
    related to VEG rewrite, where the rewritten expression had
    the wrong type.
    
    Add a cast node when the type of an expression changes after VEG rewrite
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zellerh/incubator-trafodion cses_1026

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafodion/pull/882.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #882
    
----
commit 91a809b1b7494476e1fb34696ff6496c3b492015
Author: Hans Zeller <hzeller@apache.org>
Date:   2016-12-20T22:23:52Z

    [TRAFODION-2382] No plan produced when joining two TMUDFs
    
    A simple join query resulted in no plan. One of the reasons is
    the way we handle operator types for TMUDFs. Changed this so that
    the operator type indicates the arity of the operator.

commit 1417baf4d15b45dd390c6ff1bfd6078cdf137f53
Author: Hans Zeller <hzeller@apache.org>
Date:   2016-12-20T22:26:13Z

    [TRAFODION-2399] Syntax error when loading from salted table
    
    This was caused by methods to generate an SQL string literal
    from a constant value. In some cases it repeated the character
    set name introducer.

commit 2faae457be9928909a9e84aa5bf9979944324600
Author: Hans Zeller <hzeller@apache.org>
Date:   2016-12-20T22:39:58Z

    [TRAFODION-2382] Support tinyint and boolean in tmudfs
    
    Adding support for these new data types in TMUDFs.
    
    [TRAFODION-2392] Avoid costly sort in reducer TMUDFs
    
    Adding a new function type for TMUDFs that can avoid
    a costly sort for highly reducing UDFs that implement
    an internal hash table (or equivalent).

commit 5097291082615ac4f05b302e3cc5478fb7f3dfb7
Author: Hans Zeller <hzeller@apache.org>
Date:   2016-12-20T22:40:55Z

    [TRAFODION-2400] wrong results for passthru cols
    
    Wrong results were returned for passthru columns in TMUDFs
    when we had equal predicates on the source table. This was
    related to VEG rewrite, where the rewritten expression had
    the wrong type.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message